Fix part11

This commit is contained in:
Richard Feldman
2016-09-07 02:15:02 -05:00
parent b7c8141b5e
commit c8c60e04ce
2 changed files with 66 additions and 44 deletions

View File

@@ -34,9 +34,9 @@ type alias Model =
type alias SearchOptions = type alias SearchOptions =
{ sort : String { minStars : Int
, ascending : Bool , minStarsError : Maybe String
, searchInDescription : Bool , searchIn : String
, userFilter : String , userFilter : String
} }
@@ -55,9 +55,9 @@ initialModel =
, results = [] , results = []
, errorMessage = Nothing , errorMessage = Nothing
, options = , options =
{ sort = "stars" { minStars = 0
, ascending = False , minStarsError = Nothing
, searchInDescription = True , searchIn = "name"
, userFilter = "" , userFilter = ""
} }
} }
@@ -73,6 +73,16 @@ subscriptions _ =
githubResponse decodeResponse githubResponse decodeResponse
viewMinStarsError : Maybe String -> Html msg
viewMinStarsError message =
case message of
Nothing ->
text " "
Just errorMessage ->
div [ class "stars-error" ] [ text errorMessage ]
type Msg type Msg
= Search = Search
| Options OptionsMsg | Options OptionsMsg
@@ -119,6 +129,11 @@ update msg model =
( model, Cmd.none ) ( model, Cmd.none )
onBlurWithTargetValue : (String -> msg) -> Attribute msg
onBlurWithTargetValue toMsg =
on "blur" (Json.Decode.map toMsg targetValue)
tableConfig : Table.Config SearchResult Msg tableConfig : Table.Config SearchResult Msg
tableConfig = tableConfig =
Table.config Table.config
@@ -151,14 +166,19 @@ nameColumn =
updateOptions : OptionsMsg -> SearchOptions -> SearchOptions updateOptions : OptionsMsg -> SearchOptions -> SearchOptions
updateOptions optionsMsg options = updateOptions optionsMsg options =
case optionsMsg of case optionsMsg of
SetSort sort -> SetMinStars minStarsStr ->
{ options | sort = sort } case String.toInt minStarsStr of
Ok minStars ->
{ options | minStars = minStars, minStarsError = Nothing }
SetAscending ascending -> Err _ ->
{ options | ascending = ascending } { options
| minStarsError =
Just "Must be an integer!"
}
SetSearchInDescription searchInDescription -> SetSearchIn searchIn ->
{ options | searchInDescription = searchInDescription } { options | searchIn = searchIn }
SetUserFilter userFilter -> SetUserFilter userFilter ->
{ options | userFilter = userFilter } { options | userFilter = userFilter }
@@ -217,9 +237,8 @@ viewSearchResult result =
type OptionsMsg type OptionsMsg
= SetSort String = SetMinStars String
| SetAscending Bool | SetSearchIn String
| SetSearchInDescription Bool
| SetUserFilter String | SetUserFilter String
@@ -227,11 +246,11 @@ viewOptions : SearchOptions -> Html OptionsMsg
viewOptions opts = viewOptions opts =
div [ class "search-options" ] div [ class "search-options" ]
[ div [ class "search-option" ] [ div [ class "search-option" ]
[ label [ class "top-label" ] [ text "Sort by" ] [ label [ class "top-label" ] [ text "Search in" ]
, select [ onChange SetSort, value opts.sort ] , select [ onChange SetSearchIn, value opts.searchIn ]
[ option [ value "stars" ] [ text "Stars" ] [ option [ value "name" ] [ text "Name" ]
, option [ value "forks" ] [ text "Forks" ] , option [ value "description" ] [ text "Description" ]
, option [ value "updated" ] [ text "Updated" ] , option [ value "name,description" ] [ text "Name and Description" ]
] ]
] ]
, div [ class "search-option" ] , div [ class "search-option" ]
@@ -244,13 +263,15 @@ viewOptions opts =
] ]
[] []
] ]
, label [ class "search-option" ] , div [ class "search-option" ]
[ input [ type' "checkbox", checked opts.ascending, onCheck SetAscending ] [] [ label [ class "top-label" ] [ text "Minimum Stars" ]
, text "Sort ascending" , input
] [ type' "text"
, label [ class "search-option" ] , onBlurWithTargetValue SetMinStars
[ input [ type' "checkbox", checked opts.searchInDescription, onCheck SetSearchInDescription ] [] , defaultValue (toString opts.minStars)
, text "Search in description" ]
[]
, viewMinStarsError opts.minStarsError
] ]
] ]
@@ -315,22 +336,13 @@ getQueryString model =
++ Auth.token ++ Auth.token
++ "&q=" ++ "&q="
++ model.query ++ model.query
++ (if model.options.searchInDescription then ++ "+in:"
"+in:name,description" ++ model.options.searchIn
else ++ "+stars:>="
"+in:name" ++ (toString model.options.minStars)
)
++ "+language:elm" ++ "+language:elm"
++ (if String.isEmpty model.options.userFilter then ++ (if String.isEmpty model.options.userFilter then
"" ""
else else
"+user:" ++ model.options.userFilter "+user:" ++ model.options.userFilter
) )
++ "&sort="
++ model.options.sort
++ "&order="
++ (if model.options.ascending then
"asc"
else
"desc"
)

View File

@@ -91,6 +91,15 @@ button:focus, input:focus {
outline: none; outline: none;
} }
.stars-error {
background-color: #FF9632;
font-size: 16px;
padding: 10px;
margin-right: 24px;
border-radius: 10px;
margin-top: 10px;
}
.error { .error {
background-color: #FF9632; background-color: #FF9632;
padding: 20px; padding: 20px;
@@ -103,21 +112,22 @@ button:focus, input:focus {
.search-input { .search-input {
display: block; display: block;
float: left; float: left;
width: 50%; width: 42%;
} }
.search-options { .search-options {
position: relative; position: relative;
float: right; float: right;
width: 50%; width: 58%;
box-sizing: border-box; box-sizing: border-box;
padding: 20px; padding-top: 20px;
} }
.search-option { .search-option {
display: block; display: block;
float: left; float: left;
width: 50%; width: 30%;
margin-left: 16px;
box-sizing: border-box; box-sizing: border-box;
} }