Send query string instead of whole URL to GitHub

This commit is contained in:
Richard Feldman
2016-06-25 08:55:15 -07:00
parent d3b89f4d14
commit 7f55221be7
6 changed files with 12 additions and 16 deletions

View File

@@ -4,16 +4,15 @@ import Html exposing (..)
import Html.Attributes exposing (class, target, href, property, defaultValue) import Html.Attributes exposing (class, target, href, property, defaultValue)
import Html.Events exposing (..) import Html.Events exposing (..)
import Auth import Auth
import Task exposing (Task)
import Json.Decode exposing (Decoder) import Json.Decode exposing (Decoder)
import Json.Decode.Pipeline exposing (..) import Json.Decode.Pipeline exposing (..)
import Json.Encode import Json.Encode
getQueryUrl : String -> String getQueryString : String -> String
getQueryUrl query = getQueryString query =
-- See https://developer.github.com/v3/search/#example for how to customize! -- See https://developer.github.com/v3/search/#example for how to customize!
"https://api.github.com/search/repositories?access_token=" "access_token="
++ Auth.token ++ Auth.token
++ "&q=" ++ "&q="
++ query ++ query
@@ -107,7 +106,7 @@ update : (String -> Cmd Msg) -> Msg -> Model -> ( Model, Cmd Msg )
update searchFeed msg model = update searchFeed msg model =
case msg of case msg of
Search -> Search ->
( model, searchFeed (getQueryUrl model.query) ) ( model, searchFeed (getQueryString model.query) )
SetQuery query -> SetQuery query ->
( { model | query = query }, Cmd.none ) ( { model | query = query }, Cmd.none )

View File

@@ -10,7 +10,7 @@ main =
Html.App.program Html.App.program
{ view = view { view = view
, update = update githubSearch , update = update githubSearch
, init = ( initialModel, githubSearch (getQueryUrl initialModel.query) ) , init = ( initialModel, githubSearch (getQueryString initialModel.query) )
, subscriptions = \_ -> githubResponse decodeResponse , subscriptions = \_ -> githubResponse decodeResponse
} }

View File

@@ -22,9 +22,8 @@
function searchGithub(query) { function searchGithub(query) {
console.log("Searching for", query); console.log("Searching for", query);
var search = github.getSearch(query);
search.repositories({}, function (err, repositories) { github.getSearch(query).repositories({}, function (err, repositories) {
console.log("Got response", repositories); console.log("Got response", repositories);
// TODO: app.ports.portNameGoesHere.send(repositories); // TODO: app.ports.portNameGoesHere.send(repositories);

View File

@@ -4,16 +4,15 @@ import Html exposing (..)
import Html.Attributes exposing (class, target, href, property, defaultValue) import Html.Attributes exposing (class, target, href, property, defaultValue)
import Html.Events exposing (..) import Html.Events exposing (..)
import Auth import Auth
import Task exposing (Task)
import Json.Decode exposing (Decoder) import Json.Decode exposing (Decoder)
import Json.Decode.Pipeline exposing (..) import Json.Decode.Pipeline exposing (..)
import Json.Encode import Json.Encode
getQueryUrl : String -> String getQueryString : String -> String
getQueryUrl query = getQueryString query =
-- See https://developer.github.com/v3/search/#example for how to customize! -- See https://developer.github.com/v3/search/#example for how to customize!
"https://api.github.com/search/repositories?access_token=" "access_token="
++ Auth.token ++ Auth.token
++ "&q=" ++ "&q="
++ query ++ query
@@ -107,7 +106,7 @@ update : (String -> Cmd Msg) -> Msg -> Model -> ( Model, Cmd Msg )
update searchFeed msg model = update searchFeed msg model =
case msg of case msg of
Search -> Search ->
( model, searchFeed (getQueryUrl model.query) ) ( model, searchFeed (getQueryString model.query) )
SetQuery query -> SetQuery query ->
( { model | query = query }, Cmd.none ) ( { model | query = query }, Cmd.none )

View File

@@ -10,7 +10,7 @@ main =
Html.App.program Html.App.program
{ view = view { view = view
, update = update githubSearch , update = update githubSearch
, init = ( initialModel, githubSearch (getQueryUrl initialModel.query) ) , init = ( initialModel, githubSearch (getQueryString initialModel.query) )
, subscriptions = \_ -> githubResponse decodeResponse , subscriptions = \_ -> githubResponse decodeResponse
} }

View File

@@ -22,9 +22,8 @@
function searchGithub(query) { function searchGithub(query) {
console.log("Searching for", query); console.log("Searching for", query);
var search = github.getSearch(query);
search.repositories({}, function (err, repositories) { github.getSearch(query).repositories({}, function (err, repositories) {
console.log("Got response", repositories); console.log("Got response", repositories);
app.ports.githubResponse.send(repositories); app.ports.githubResponse.send(repositories);