From 260ac20815e5a2c8ce0acc6ee28a77012b22c31a Mon Sep 17 00:00:00 2001 From: Richard Feldman Date: Fri, 2 Sep 2016 22:32:55 -0700 Subject: [PATCH] Clean up part10 --- part10/Main.elm | 27 +++++++++------------------ part10/index.html | 4 ---- 2 files changed, 9 insertions(+), 22 deletions(-) diff --git a/part10/Main.elm b/part10/Main.elm index cb7af06..357ea38 100644 --- a/part10/Main.elm +++ b/part10/Main.elm @@ -37,8 +37,7 @@ subscriptions model = case model of Home pageModel -> -- TODO use Sub.map to translate from Page.Home.subscriptions - Page.Home.subscriptions pageModel - |> Sub.map HomeMsg + Sub.none Repository pageModel -> -- Repository has no subscriptions, so there's nothing to translate! @@ -54,13 +53,11 @@ init result = case result of Ok (Page.Home) -> -- TODO use Html.map to translate from Page.Home.view - Page.Home.init - |> Tuple2.mapEach Home (Cmd.map HomeMsg) + ( NotFound, Cmd.none ) Ok (Page.Repository repoOwner repoName) -> -- TODO use Html.map to translate from Page.Repository.view - Page.Repository.init repoOwner repoName - |> Tuple2.mapEach Repository (Cmd.map RepositoryMsg) + ( NotFound, Cmd.none ) Ok (Page.NotFound) -> ( NotFound, Cmd.none ) @@ -75,13 +72,11 @@ view model = case model of Home pageModel -> -- TODO use Html.map to translate from Page.Home.view - Page.Home.view pageModel - |> Html.map HomeMsg + text "Nothing to see here yet. Still need to translate Home!" Repository pageModel -> -- TODO use Html.map to translate from Page.Repository.view - Page.Repository.view pageModel - |> Html.map RepositoryMsg + text "Nothing to see here yet. Still need to translate Repository!" NotFound -> h1 [] [ text "Page Not Found" ] @@ -106,14 +101,12 @@ update msg model = -- to translate from Page.Home.update -- -- mapEach : (a -> newA) -> (b -> newB) -> ( a, b ) -> ( newA, newB ) - Page.Home.update pageMsg pageModel - |> Tuple2.mapEach Home (Cmd.map HomeMsg) + ( model, Cmd.none ) ( RepositoryMsg pageMsg, Repository pageModel ) -> -- TODO use Tuple2.mapEach and (Cmd.map RepositoryMsg) -- to translate from Page.Repository.update - Page.Repository.update pageMsg pageModel - |> Tuple2.mapEach Repository (Cmd.map RepositoryMsg) + ( model, Cmd.none ) _ -> ( model, Cmd.none ) @@ -127,16 +120,14 @@ urlUpdate result model = -- to translate from Page.Home.init -- -- mapEach : (a -> newA) -> (b -> newB) -> ( a, b ) -> ( newA, newB ) - Page.Home.init - |> Tuple2.mapEach Home (Cmd.map HomeMsg) + ( model, Cmd.none ) Ok (Page.Repository repoOwner repoName) -> -- TODO use Tuple2.mapEach and (Cmd.map RepositoryMsg) -- to translate from Page.Repository.init -- -- HINT: Page.Repository.init is a function that takes 2 arguments. - Page.Repository.init repoOwner repoName - |> Tuple2.mapEach Repository (Cmd.map RepositoryMsg) + ( model, Cmd.none ) Ok (Page.NotFound) -> ( NotFound, Cmd.none ) diff --git a/part10/index.html b/part10/index.html index 0e6f8e9..a36a302 100644 --- a/part10/index.html +++ b/part10/index.html @@ -21,11 +21,7 @@ var app = Elm.Main.embed(document.getElementById("elm-landing-pad")); function searchGithub(query) { - console.log("Searching for", query); - github.getSearch(query).repositories({}, function (err, repositories) { - console.log("Got response", repositories); - app.ports.githubResponse.send(repositories); }); }